Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update Youku.com.xml - #7986

Merged
J0WI merged 9 commits into
EFForg:masterfrom
ivysrono:patch-382
Feb 22, 2017
Merged

J0WI merged 9 commits into
EFForg:masterfrom
ivysrono:patch-382

Conversation

@ivysrono

Copy link
Copy Markdown
Contributor

No description provided.

@ivysrono

Copy link
Copy Markdown
Contributor Author

Related: #7785

@ivysrono ivysrono closed this Dec 28, 2016
@ivysrono ivysrono reopened this Dec 28, 2016
@ivysrono

ivysrono commented Feb 21, 2017 •

Copy link
Copy Markdown
Contributor Author

@J0WI Would you review this biggest Chinese video site?
Thanks.

@J0WI

J0WI commented Feb 21, 2017

Copy link
Copy Markdown
Contributor

Please see also:
hudong.pl.youku.com
p.comments.youku.com
ykrec.youku.com

Is this related to ykimg.com.xml?

@J0WI

J0WI commented Feb 21, 2017

Copy link
Copy Markdown
Contributor

@Hainish I wonder why this has not been flagged as a top-* alexa rank host

@Hainish

Hainish commented Feb 21, 2017

Copy link
Copy Markdown
Member

@J0WI looks like this was a bug, fixed in 6f28364

@ivysrono

ivysrono commented Feb 22, 2017 •

Copy link
Copy Markdown
Contributor Author

@J0WI hudong.pl.youku.com existed.

@Hainish For my opening 26 PRs https://github.com/EFForg/https-everywhere/pulls/ivysrono
only 4 of them have top-* flag.

@J0WI
J0WI merged commit 83d1441 into EFForg:master Feb 22, 2017
@Hainish

Hainish commented Feb 22, 2017

Copy link
Copy Markdown
Member

@ivysrono the next time the labeller is run, it will look back through all the open PRs and label them appropriately.

@ivysrono

Copy link
Copy Markdown
Contributor Author

@Hainish
There are 7/22 PRs no label.
Why?
Especially #7413 #8557 are so popular.

@Folant

Folant commented Feb 23, 2017

Copy link
Copy Markdown
Contributor

@ivysrono
Maybe because it checks only targets (from this list) and not ruleset name.

function rank_targets(targets){
var minimum_placing = 9999999;
_.each(targets, function(host){
if(host.match(wildcard_www_regex)){
host = host.match(wildcard_www_regex)[2];
}

19624,fanli.com is not present in Fanli.com.xml
and
1313,58.com not present in 58.com.xml

@ivysrono

Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants